RE: [EXT] [PATCH 15/30] scsi: qla2xxx: qla_iocb: Replace __qla2x00_marker()'s missing underscores

From: Nilesh Javali
Date: Wed Mar 03 2021 - 13:38:31 EST




> -----Original Message-----
> From: Lee Jones <lee.jones@xxxxxxxxxx>
> Sent: Wednesday, March 3, 2021 8:16 PM
> To: lee.jones@xxxxxxxxxx
> Cc: linux-kernel@xxxxxxxxxxxxxxx; Nilesh Javali <njavali@xxxxxxxxxxx>; GR-
> QLogic-Storage-Upstream <GR-QLogic-Storage-Upstream@xxxxxxxxxxx>;
> James E.J. Bottomley <jejb@xxxxxxxxxxxxx>; Martin K. Petersen
> <martin.petersen@xxxxxxxxxx>; linux-scsi@xxxxxxxxxxxxxxx
> Subject: [EXT] [PATCH 15/30] scsi: qla2xxx: qla_iocb: Replace
> __qla2x00_marker()'s missing underscores
>
> External Email
>
> ----------------------------------------------------------------------
> Fixes the following W=1 kernel build warning(s):
>
> drivers/scsi/qla2xxx/qla_iocb.c:508: warning: expecting prototype for
> qla2x00_marker(). Prototype was for __qla2x00_marker() instead
>
> Cc: Nilesh Javali <njavali@xxxxxxxxxxx>
> Cc: GR-QLogic-Storage-Upstream@xxxxxxxxxxx
> Cc: "James E.J. Bottomley" <jejb@xxxxxxxxxxxxx>
> Cc: "Martin K. Petersen" <martin.petersen@xxxxxxxxxx>
> Cc: linux-scsi@xxxxxxxxxxxxxxx
> Signed-off-by: Lee Jones <lee.jones@xxxxxxxxxx>
> ---
> drivers/scsi/qla2xxx/qla_iocb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/qla2xxx/qla_iocb.c b/drivers/scsi/qla2xxx/qla_iocb.c
> index 8b41cbaf8535b..e765ee4ce162a 100644
> --- a/drivers/scsi/qla2xxx/qla_iocb.c
> +++ b/drivers/scsi/qla2xxx/qla_iocb.c
> @@ -491,7 +491,7 @@ qla2x00_start_iocbs(struct scsi_qla_host *vha, struct
> req_que *req)
> }
>
> /**
> - * qla2x00_marker() - Send a marker IOCB to the firmware.
> + * __qla2x00_marker() - Send a marker IOCB to the firmware.
> * @vha: HA context
> * @qpair: queue pair pointer
> * @loop_id: loop ID
> --
> 2.27.0

Lee,

Thanks for the patch.
Ack-by: Nilesh Javali <njavali@xxxxxxxxxxx>