RE: [EXT] [PATCH 19/30] scsi: qla4xxx: ql4_mbx: Fix kernel-doc formatting and misnaming issue

[Nilesh Javali]

> -----Original Message-----
> From: Lee Jones <lee.jones@xxxxxxxxxx>
> Sent: Wednesday, March 3, 2021 8:16 PM
> To: lee.jones@xxxxxxxxxx
> Cc: linux-kernel@xxxxxxxxxxxxxxx; Nilesh Javali <njavali@xxxxxxxxxxx>;
> Manish Rangankar <mrangankar@xxxxxxxxxxx>; GR-QLogic-Storage-
> Upstream <GR-QLogic-Storage-Upstream@xxxxxxxxxxx>; James E.J.
> Bottomley <jejb@xxxxxxxxxxxxx>; Martin K. Petersen
> <martin.petersen@xxxxxxxxxx>; linux-scsi@xxxxxxxxxxxxxxx
> Subject: [EXT] [PATCH 19/30] scsi: qla4xxx: ql4_mbx: Fix kernel-doc
> formatting and misnaming issue
> 
> External Email
> 
> ----------------------------------------------------------------------
> Fixes the following W=1 kernel build warning(s):
> 
>  drivers/scsi/qla4xxx/ql4_mbx.c:47: warning: wrong kernel-doc identifier on
> line:
>  drivers/scsi/qla4xxx/ql4_mbx.c:947: warning: expecting prototype for
> qla4xxx_set_fwddb_entry(). Prototype was for qla4xxx_set_ddb_entry()
> instead
> 
> Cc: Nilesh Javali <njavali@xxxxxxxxxxx>
> Cc: Manish Rangankar <mrangankar@xxxxxxxxxxx>
> Cc: GR-QLogic-Storage-Upstream@xxxxxxxxxxx
> Cc: "James E.J. Bottomley" <jejb@xxxxxxxxxxxxx>
> Cc: "Martin K. Petersen" <martin.petersen@xxxxxxxxxx>
> Cc: linux-scsi@xxxxxxxxxxxxxxx
> Signed-off-by: Lee Jones <lee.jones@xxxxxxxxxx>
> ---
>  drivers/scsi/qla4xxx/ql4_mbx.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/scsi/qla4xxx/ql4_mbx.c b/drivers/scsi/qla4xxx/ql4_mbx.c
> index 17b719a8b6fbc..187d78aa4f675 100644
> --- a/drivers/scsi/qla4xxx/ql4_mbx.c
> +++ b/drivers/scsi/qla4xxx/ql4_mbx.c
> @@ -44,7 +44,7 @@ void qla4xxx_process_mbox_intr(struct scsi_qla_host
> *ha, int out_count)
>  }
> 
>  /**
> - * qla4xxx_is_intr_poll_mode – Are we allowed to poll for interrupts?
> + * qla4xxx_is_intr_poll_mode - Are we allowed to poll for interrupts?
>   * @ha: Pointer to host adapter structure.
>   * returns: 1=polling mode, 0=non-polling mode
>   **/
> @@ -933,7 +933,7 @@ int qla4xxx_conn_open(struct scsi_qla_host *ha,
> uint16_t fw_ddb_index)
>  }
> 
>  /**
> - * qla4xxx_set_fwddb_entry - sets a ddb entry.
> + * qla4xxx_set_ddb_entry - sets a ddb entry.
>   * @ha: Pointer to host adapter structure.
>   * @fw_ddb_index: Firmware's device database index
>   * @fw_ddb_entry_dma: dma address of ddb entry
> --
> 2.27.0

Lee,

Thanks for the patch.
Ack-by: Nilesh Javali <njavali@xxxxxxxxxxx>