Re: [PATCH drivers/net] #ifdef mdio_bus_phy_suspend() and mdio_bus_phy_suspend()

From: Russell King - ARM Linux admin
Date: Wed Mar 03 2021 - 14:07:18 EST


On Wed, Mar 03, 2021 at 09:53:38AM -0800, Paul E. McKenney wrote:
> drivers/net: #ifdef mdio_bus_phy_suspend() and mdio_bus_phy_suspend()
>
> The following build error is emitted by rcutorture builds of v5.12-rc1:
>
> drivers/net/phy/phy_device.c:293:12: warning: ‘mdio_bus_phy_resume’ defined but not used [-Wunused-function]
> drivers/net/phy/phy_device.c:273:12: warning: ‘mdio_bus_phy_suspend’ defined but not used [-Wunused-function]
>
> The problem is that these functions are only used by SIMPLE_DEV_PM_OPS(),
> which creates a dev_pm_ops structure only in CONFIG_PM_SLEEP=y kernels.
> Therefore, the mdio_bus_phy_suspend() and mdio_bus_phy_suspend() functions
> will be used only in CONFIG_PM_SLEEP=y kernels. This commit therefore
> wraps them in #ifdef CONFIG_PM_SLEEP.

Arnd submitted a patch that Jakub has applied which fix these warnings
in a slightly different way. Please see
20210225145748.404410-1-arnd@xxxxxxxxxx

--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!