Re: [PATCH v17 1/9] mm: memory_hotplug: factor out bootmem core functions to bootmem_info.c

[Balbir Singh]

On Wed, Mar 03, 2021 at 01:45:00PM +1100, Singh, Balbir wrote:
> On 26/2/21 12:21 am, Muchun Song wrote:
> > Move bootmem info registration common API to individual bootmem_info.c.
> > And we will use {get,put}_page_bootmem() to initialize the page for the
> > vmemmap pages or free the vmemmap pages to buddy in the later patch.
> > So move them out of CONFIG_MEMORY_HOTPLUG_SPARSE. This is just code
> > movement without any functional change.
> > 
> > Signed-off-by: Muchun Song <songmuchun@xxxxxxxxxxxxx>
> > Acked-by: Mike Kravetz <mike.kravetz@xxxxxxxxxx>
> > Reviewed-by: Oscar Salvador <osalvador@xxxxxxx>
> > Reviewed-by: David Hildenbrand <david@xxxxxxxxxx>
> > Reviewed-by: Miaohe Lin <linmiaohe@xxxxxxxxxx>
> ...
> 
> > diff --git a/mm/bootmem_info.c b/mm/bootmem_info.c
> > new file mode 100644
> > index 000000000000..fcab5a3f8cc0
> > --- /dev/null
> > +++ b/mm/bootmem_info.c
> > @@ -0,0 +1,124 @@
> > +// SPDX-License-Identifier: GPL-2.0
> > +/*
> > + *  linux/mm/bootmem_info.c
> > + *
> > + *  Copyright (C)
> 
> Looks like incomplete
>
Not that my comment was, I should have said

The copyright looks very incomplete

Balbir Singh.