Re: [PATCH] crypto: qat - fix use of 'dma_map_single'

From: Dan Carpenter
Date: Thu Mar 04 2021 - 08:43:31 EST

Next message:
Previous
In reply
Messages

Hi Hui,

url: If you fix the issue, Reported-by: kernel Reported-by: Dan Carpenter
smatch warnings:
drivers/crypto/qat/qat_commo
vim +/blp +809 drivers/crypt
d370cec3219490 Tadeusz Struk d370cec3219490 Tadeusz Struk e19ab1211d2848 Herbert Xu d370cec3219490 Tadeusz Struk d370cec3219490 Tadeusz Struk d370cec3219490 Tadeusz Struk e19ab1211d2848 Herbert Xu e19ab1211d2848 Herbert Xu d370cec3219490 Tadeusz Struk d370cec3219490 Tadeusz Struk d370cec3219490 Tadeusz Struk
d370cec3219490 Tadeusz Struk d370cec3219490 Tadeusz Struk 1793d1aba19415 Gustavo d370cec3219490 Tadeusz Struk d370cec3219490 Tadeusz Struk d370cec3219490 Tadeusz Struk d370cec3219490 Tadeusz Struk 82f82504b8f5f1 Tadeusz Struk 09adc8789c4e89 Tadeusz Struk d370cec3219490 Tadeusz Struk d370cec3219490 Tadeusz Struk d370cec3219490 Tadeusz Struk d370cec3219490 Tadeusz Struk e19ab1211d2848 Herbert Xu 82f82504b8f5f1 Tadeusz Struk 82f82504b8f5f1 Tadeusz Struk 82f82504b8f5f1 Tadeusz Struk d65071ecde1ed1 Tadeusz Struk d370cec3219490 Tadeusz Struk d370cec3219490 Tadeusz Struk d370cec3219490 Tadeusz Struk d370cec3219490 Tadeusz Struk d370cec3219490 Tadeusz Struk 72eed063767e13 Arnd Bergmann
"blp" uninitialized
82f82504b8f5f1 Tadeusz Struk d370cec3219490 Tadeusz Struk e19ab1211d2848 Herbert Xu 54bc41cf4d0517 Hui Tang Initialized here.

54bc41cf4d0517 Hui Tang 54bc41cf4d0517 Hui Tang d370cec3219490 Tadeusz Struk d370cec3219490 Tadeusz Struk d370cec3219490 Tadeusz Struk d370cec3219490 Tadeusz Struk d370cec3219490 Tadeusz Struk d370cec3219490 Tadeusz Struk d370cec3219490 Tadeusz Struk 82f82504b8f5f1 Tadeusz Struk 1793d1aba19415 Gustavo 82f82504b8f5f1 Tadeusz Struk 82f82504b8f5f1 Tadeusz Struk 09adc8789c4e89 Tadeusz Struk d370cec3219490 Tadeusz Struk 72eed063767e13 Arnd Bergmann d370cec3219490 Tadeusz Struk d370cec3219490 Tadeusz Struk e19ab1211d2848 Herbert Xu 82f82504b8f5f1 Tadeusz Struk 82f82504b8f5f1 Tadeusz Struk 82f82504b8f5f1 Tadeusz Struk d65071ecde1ed1 Tadeusz Struk d370cec3219490 Tadeusz Struk d370cec3219490 Tadeusz Struk d370cec3219490 Tadeusz Struk d370cec3219490 Tadeusz Struk 72eed063767e13 Arnd Bergmann 82f82504b8f5f1 Tadeusz Struk 82f82504b8f5f1 Tadeusz Struk d370cec3219490 Tadeusz Struk e19ab1211d2848 Herbert Xu 82f82504b8f5f1 Tadeusz Struk 54bc41cf4d0517 Hui Tang 54bc41cf4d0517 Hui Tang 54bc41cf4d0517 Hui Tang d370cec3219490 Tadeusz Struk d370cec3219490 Tadeusz Struk 82f82504b8f5f1 Tadeusz Struk d370cec3219490 Tadeusz Struk d370cec3219490 Tadeusz Struk d370cec3219490 Tadeusz Struk 82f82504b8f5f1 Tadeusz Struk d370cec3219490 Tadeusz Struk d370cec3219490 Tadeusz Struk 82f82504b8f5f1 Tadeusz Struk 72eed063767e13 Arnd Bergmann 54bc41cf4d0517 Hui Tang 54bc41cf4d0517 Hui Tang 54bc41cf4d0517 Hui Tang 82f82504b8f5f1 Tadeusz Struk e19ab1211d2848 Herbert Xu 82f82504b8f5f1 Tadeusz Struk 82f82504b8f5f1 Tadeusz Struk 82f82504b8f5f1 Tadeusz Struk d370cec3219490 Tadeusz Struk d370cec3219490 Tadeusz Struk 72eed063767e13 Arnd Bergmann 72eed063767e13 Arnd Bergmann 54bc41cf4d0517 Hui Tang Uninitialized.

54bc41cf4d0517 Hui Tang 54bc41cf4d0517 Hui Tang 72eed063767e13 Arnd Bergmann 72eed063767e13 Arnd Bergmann 72eed063767e13 Arnd Bergmann 72eed063767e13 Arnd Bergmann 72eed063767e13 Arnd Bergmann 72eed063767e13 Arnd Bergmann 72eed063767e13 Arnd Bergmann 72eed063767e13 Arnd Bergmann 72eed063767e13 Arnd Bergmann 72eed063767e13 Arnd Bergmann d370cec3219490 Tadeusz Struk d370cec3219490 Tadeusz Struk
---
0-DAY CI Kernel Test Attachment: Description: application/gzip Rafael J. Wysocki: "Re: [PATCH v1 4/4] gpiolib: Reuse device's fwnode to create IRQ domain" message: Tom Rix: "Re: [PATCH V3 XRT Alveo 13/18] fpga: xrt: devctl platform driver" to: kernel test robot: "Re: [PATCH] crypto: qat - fix use of 'dma_map_single'" sorted by: [ date ] [ thread ] [ subject ] [ author ] href="https://github.com/0day-ci/linux/commits/Hui-Tang/crypto-qat-fix-use-of-dma_map_single/20210301-114717">https://github.com/0day-ci/linux/commits/Hui-Tang/crypto-qat-fix-use-of-dma_map_single/20210301-114717
href="https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git">https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git master
(attached as .config)
9.3.0-22) 9.3.0
kindly add following tag as appropriate
test robot <lkp@xxxxxxxxx>
<dan.carpenter@xxxxxxxxxx>
n/qat_algs.c:809 qat_alg_sgl_to_bufl() error: uninitialized symbol 'blp'.
o/qat/qat_common/qat_algs.c
2014-06-05 711 static int qat_alg_sgl_to_bufl(struct qat_crypto_instance *inst,
2014-06-05 712 struct scatterlist *sgl,
2015-07-30 713 struct scatterlist *sglout,
2014-06-05 714 struct qat_crypto_request *qat_req)
2014-06-05 715 {
2014-06-05 716 struct device *dev = &GET_DEV(inst->accel_dev);
2015-07-30 717 int i, sg_nctr = 0;
2015-07-30 718 int n = sg_nents(sgl);
2014-06-05 719 struct qat_alg_buf_list *bufl;
2014-06-05 720 struct qat_alg_buf_list *buflout = NULL;
2014-06-05 721 dma_addr_t blp;
^^^^^^^^^^^^^^
2014-06-05 722 dma_addr_t bloutp = 0;
2014-06-05 723 struct scatterlist *sg;
A. R. Silva 2019-06-06 724 size_t sz_out, sz = struct_size(bufl, bufers, n + 1);
2014-06-05 725
2014-06-05 726 if (unlikely(!n))
2014-06-05 727 return -EINVAL;
2014-06-05 728
2014-12-08 729 bufl = kzalloc_node(sz, GFP_ATOMIC,
2014-10-13 730 dev_to_node(&GET_DEV(inst->accel_dev)));
2014-06-05 731 if (unlikely(!bufl))
2014-06-05 732 return -ENOMEM;
2014-06-05 733
2014-06-05 734 for_each_sg(sgl, sg, n, i) {
2015-07-30 735 int y = sg_nctr;
2014-12-08 736
2014-12-08 737 if (!sg->length)
2014-12-08 738 continue;
2014-06-24 739
2014-06-05 740 bufl->bufers[y].addr = dma_map_single(dev, sg_virt(sg),
2014-06-05 741 sg->length,
2014-06-05 742 DMA_BIDIRECTIONAL);
2014-06-05 743 bufl->bufers[y].len = sg->length;
2014-06-05 744 if (unlikely(dma_mapping_error(dev, bufl->bufers[y].addr)))
2017-06-22 745 goto err_in;
at this goto.
2014-12-08 746 sg_nctr++;
2014-06-05 747 }
2015-07-30 748 bufl->num_bufs = sg_nctr;
2021-03-01 749 blp = dma_map_single(dev, bufl, sz, DMA_TO_DEVICE);
^^^^^^
2021-03-01 750 if (unlikely(dma_mapping_error(dev, blp)))
2021-03-01 751 goto err_in;
2014-06-05 752 qat_req->buf.bl = bufl;
2014-06-05 753 qat_req->buf.blp = blp;
2014-06-05 754 qat_req->buf.sz = sz;
2014-06-05 755 /* Handle out of place operation */
2014-06-05 756 if (sgl != sglout) {
2014-06-05 757 struct qat_alg_buf *bufers;
2014-06-05 758
2014-12-08 759 n = sg_nents(sglout);
A. R. Silva 2019-06-06 760 sz_out = struct_size(buflout, bufers, n + 1);
2014-12-08 761 sg_nctr = 0;
2014-12-08 762 buflout = kzalloc_node(sz_out, GFP_ATOMIC,
2014-10-13 763 dev_to_node(&GET_DEV(inst->accel_dev)));
2014-06-05 764 if (unlikely(!buflout))
2017-06-22 765 goto err_in;
2014-06-05 766 bufers = buflout->bufers;
2014-06-05 767 for_each_sg(sglout, sg, n, i) {
2015-07-30 768 int y = sg_nctr;
2014-12-08 769
2014-12-08 770 if (!sg->length)
2014-12-08 771 continue;
2014-06-24 772
2014-06-05 773 bufers[y].addr = dma_map_single(dev, sg_virt(sg),
2014-06-05 774 sg->length,
2014-06-05 775 DMA_BIDIRECTIONAL);
2014-06-05 776 if (unlikely(dma_mapping_error(dev, bufers[y].addr)))
2017-06-22 777 goto err_out;
2014-12-08 778 bufers[y].len = sg->length;
2014-12-08 779 sg_nctr++;
2014-06-05 780 }
2015-07-30 781 buflout->num_bufs = sg_nctr;
2014-12-08 782 buflout->num_mapped_bufs = sg_nctr;
2021-03-01 783 bloutp = dma_map_single(dev, buflout, sz_out, DMA_TO_DEVICE);
2021-03-01 784 if (unlikely(dma_mapping_error(dev, bloutp)))
2021-03-01 785 goto err_out;
2014-06-05 786 qat_req->buf.blout = buflout;
2014-06-05 787 qat_req->buf.bloutp = bloutp;
2014-12-08 788 qat_req->buf.sz_out = sz_out;
2014-06-05 789 } else {
2014-06-05 790 /* Otherwise set the src and dst to the same address */
2014-06-05 791 qat_req->buf.bloutp = qat_req->buf.blp;
2014-12-08 792 qat_req->buf.sz_out = 0;
2014-06-05 793 }
2014-06-05 794 return 0;
2014-12-08 795
2017-06-22 796 err_out:
2021-03-01 797 if (!dma_mapping_error(dev, bloutp))
2021-03-01 798 dma_unmap_single(dev, bloutp, sz_out, DMA_TO_DEVICE);
2021-03-01 799
2014-12-08 800 n = sg_nents(sglout);
2015-07-30 801 for (i = 0; i < n; i++)
2014-12-08 802 if (!dma_mapping_error(dev, buflout->bufers[i].addr))
2014-12-08 803 dma_unmap_single(dev, buflout->bufers[i].addr,
2014-12-08 804 buflout->bufers[i].len,
2014-06-05 805 DMA_BIDIRECTIONAL);
2014-06-05 806 kfree(buflout);
2017-06-22 807
2017-06-22 808 err_in:
2021-03-01 @809 if (!dma_mapping_error(dev, blp))
^^^
2021-03-01 810 dma_unmap_single(dev, blp, sz, DMA_TO_DEVICE);
2021-03-01 811
2017-06-22 812 n = sg_nents(sgl);
2017-06-22 813 for (i = 0; i < n; i++)
2017-06-22 814 if (!dma_mapping_error(dev, bufl->bufers[i].addr))
2017-06-22 815 dma_unmap_single(dev, bufl->bufers[i].addr,
2017-06-22 816 bufl->bufers[i].len,
2017-06-22 817 DMA_BIDIRECTIONAL);
2017-06-22 818
2017-06-22 819 kfree(bufl);
2017-06-22 820
2017-06-22 821 dev_err(dev, "Failed to map buf for dma\n");
2014-06-05 822 return -ENOMEM;
2014-06-05 823 }
Service, Intel Corporation
href="https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx">https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx
>.config.gz

Next message: Rafael J. Wysocki: "Re: [PATCH v1 4/4] gpiolib: Reuse device's fwnode to create IRQ domain"
Previous message: Tom Rix: "Re: [PATCH V3 XRT Alveo 13/18] fpga: xrt: devctl platform driver"
In reply to: kernel test robot: "Re: [PATCH] crypto: qat - fix use of 'dma_map_single'"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]