Re: [PATCH] ibmvnic: remove excessive irqsave

[Sukadev Bhattiprolu]

angkery [angkery@xxxxxxx] wrote:
> From: Junlin Yang <yangjunlin@xxxxxxxxxx>
> 
> ibmvnic_remove locks multiple spinlocks while disabling interrupts:
> spin_lock_irqsave(&adapter->state_lock, flags);
> spin_lock_irqsave(&adapter->rwi_lock, flags);
> 
> there is no need for the second irqsave,since interrupts are disabled
> at that point, so remove the second irqsave:
> spin_lock_irqsave(&adapter->state_lock, flags);
> spin_lock(&adapter->rwi_lock);
> 
> Generated by: ./scripts/coccinelle/locks/flags.cocci
> ./drivers/net/ethernet/ibm/ibmvnic.c:5413:1-18:
> ERROR: nested lock+irqsave that reuses flags from line 5404.
> 

Thanks. Please add

Fixes: 4a41c421f367 ("ibmvnic: serialize access to work queue on remove")

> Signed-off-by: Junlin Yang <yangjunlin@xxxxxxxxxx>

Reviewed-by: Sukadev Bhattiprolu <sukadev@xxxxxxxxxxxxx>