Re: [PATCH 1/3] input: gpio-keys: Remove extra call to input_sync

From: Dmitry Torokhov
Date: Fri Mar 05 2021 - 13:40:52 EST


On Fri, Mar 05, 2021 at 05:01:09PM +0000, Paul Cercueil wrote:
> The input_sync() function will already be called within
> gpio_keys_gpio_report_event(), so there's no need to call it again after
> the loop in gpio_keys_report_state().

I'd probably go other way around and remove the sync from
gpio_keys_report_state() and add one to gpio_keys_gpio_work_func() so
that we do not have to send bunch of input_sync() when there are several
keys/buttons.

Thanks.

--
Dmitry