Re: [PATCH] tools/memory-model: Fix smp_mb__after_spinlock() spelling

From: Paul E. McKenney
Date: Fri Mar 05 2021 - 14:10:44 EST


On Fri, Mar 05, 2021 at 01:59:24PM -0500, Alan Stern wrote:
> On Fri, Mar 05, 2021 at 10:26:50AM -0800, Paul E. McKenney wrote:
> > On Fri, Mar 05, 2021 at 04:41:49PM +0100, Björn Töpel wrote:
> > > On 2021-03-05 16:36, Alan Stern wrote:
> > > > On Fri, Mar 05, 2021 at 11:28:23AM +0100, Björn Töpel wrote:
> > > > > From: Björn Töpel <bjorn.topel@xxxxxxxxx>
> > > > >
> > > > > A misspelled invokation of git-grep, revealed that
> > > > -------------------^
> > > >
> > > > Smetimes my brain is a little slow... Do you confirm that this is a
> > > > joke?
> > > >
> > >
> > > I wish, Alan. I wish.
> > >
> > > Looks like I can only spel function names correctly.
> >
> > Heh! I missed that one completely. Please see below for a wortschmied
> > commit.
> >
> > Thanx, Paul
> >
> > ------------------------------------------------------------------------
> >
> > commit 1c737ce34715db9431f6b034f92dbf09d954126d
> > Author: Björn Töpel <bjorn.topel@xxxxxxxxx>
> > Date: Fri Mar 5 11:28:23 2021 +0100
> >
> > tools/memory-model: Fix smp_mb__after_spinlock() spelling
> >
> > A misspelled git-grep regex revealed that smp_mb__after_spinlock()
> > was misspelled in explanation.txt.
> >
> > This commit adds the missing "_" to smp_mb__after_spinlock().
>
> Strictly speaking, the commit adds a missing "_" to
> smp_mb_after_spinlock(). If it added anything to
> smp_mb__after_spinlock(), the result would be incorrect.
>
> How about just:
>
> A misspelled git-grep regex revealed that smp_mb__after_spinlock()
> was misspelled in explanation.txt. This commit adds the missing "_".

Very good, updated as you suggest, thank you!

Thanx, Paul