Re: [PATCH] media: platform: sunxi: sun6i-csi: fix error return code of sun6i_video_start_streaming()

From: Jia-Ju Bai
Date: Sun Mar 07 2021 - 21:54:58 EST




On 2021/3/7 20:47, Chen-Yu Tsai wrote:
On Sat, Mar 6, 2021 at 10:15 PM Jia-Ju Bai <baijiaju1990@xxxxxxxxx> wrote:
When sun6i_video_remote_subdev() returns NULL to subdev, no error return
code of sun6i_video_start_streaming() is assigned.
To fix this bug, ret is assigned with -EINVAL in this case.

Reported-by: TOTE Robot <oslab@xxxxxxxxxxxxxxx>
Signed-off-by: Jia-Ju Bai <baijiaju1990@xxxxxxxxx>
This should have the tag:

Fixes: 5cc7522d8965 ("media: sun6i: Add support for Allwinner CSI V3s")

Please try to add them when fixing bugs. And this should also be tagged
for stable, so

Cc: <stable@xxxxxxxxxx>

Otherwise,

Acked-by: Chen-Yu Tsai <wens@xxxxxxxx>

Thanks for the advice :)
I will add the fixes and stable tags in my future patches.


Best wishes,
Jia-Ju Bai