Re: [PATCH v7 2/4] perf tools: Add lexical definition of event name

From: nakamura.shun@xxxxxxxxxxx
Date: Sun Mar 07 2021 - 22:20:57 EST


Hi, jirka

> > > > From: Shunsuke Nakamura <nakamura.shun@xxxxxxxxxxxxxx>
> > > >
> > > > Add the lexical definition of event name so that the numbers are recognizable.
> > > >
> > >
> > > Sorry for the hassle, but it's not clear that we got a definitive
> > > conclusion on this patch from v6 series:
> > >
> > > https://lore.kernel.org/lkml/YCuo01Wxxe%2FMCrC5@krava/
> > >
> > > Would it be so much worse for you to change format of these event names
> > > to not start with a numberic?
> > I was trying to match the specifications published by Fujitsu exactly.
> > We also thought that being able to parse event names starting with a number would be an improvement for perf.
> > We've discussed it with the team, but we decided to change the event name.
>
> hum, I'm not sure what's the final decision in here.. are you keeping
> numbers in the start? would be much easier if you did not ;-)
I don't keep the event name starting with a number.

v8 patch serase changed the event name starting with a number to start with "_".
https://lore.kernel.org/linux-arm-kernel/20210305101841.3133721-1-nakamura.shun@xxxxxxxxxxx/

Best Regards
Shunsuke