Re: [PATCH] Revert "arm64: dts: amlogic: add missing ethernet reset ID"

From: Neil Armstrong
Date: Mon Mar 08 2021 - 03:58:52 EST


On 03/03/2021 00:28, Kevin Hilman wrote:
> Hi Neil,
>
> Neil Armstrong <narmstrong@xxxxxxxxxxxx> writes:
>
>> It has been reported on IRC and in KernelCI boot tests, this change breaks
>> internal PHY support on the Amlogic G12A/SM1 Based boards.
>>
>> We suspect the added signal to reset more than the Ethernet MAC but also
>> the MDIO/(RG)MII mux used to redirect the MAC signals to the internal PHY.
>>
>> This reverts commit f3362f0c18174a1f334a419ab7d567a36bd1b3f3 while we find
>> and acceptable solution to cleanly reset the Ethernet MAC.
>>
>> Reported-by: Corentin Labbe <clabbe@xxxxxxxxxxxx>
>> Acked-by: Jérôme Brunet <jbrunet@xxxxxxxxxxxx>
>> Signed-off-by: Neil Armstrong <narmstrong@xxxxxxxxxxxx>
>> ---
>> Hi Kevin,
>>
>> This has been reported to also break on 5.10, when this lands on 5.11, I'll send another
>> patch for 5.10 because meson-axg.dtsi needs a conflict resolution on 5.11.
>
> Looks like this never got submitted to v5.10. I just discovered it that
> v5.10 in SEI610 (internal PHY) is broken.
>
> Could you submit this to v5.10 stable also please?

Sure, I'll prepare this.

Neil

>
> Thanks,
>
> Kevin
>
>
>
>
>