Re: [LTP] [f2fs] 02eb84b96b: ltp.swapon03.fail

From: Richard Palethorpe
Date: Mon Mar 08 2021 - 06:54:36 EST


Hello,

> kern :err : [ 187.461914] F2FS-fs (sda1): Swapfile does not align to section

> commit 02eb84b96bc1b382dd138bf60724edbefe77b025
> Author: huangjianan@xxxxxxxx <huangjianan@xxxxxxxx>
> Date: Mon Mar 1 12:58:44 2021 +0800

> f2fs: check if swapfile is section-alligned

> If the swapfile isn't created by pin and fallocate, it can't be
> guaranteed section-aligned, so it may be selected by f2fs gc. When
> gc_pin_file_threshold is reached, the address of swapfile may change,
> but won't be synchronized to swap_extent, so swap will write to wrong
> address, which will cause data corruption.

> Signed-off-by: Huang Jianan <huangjianan@xxxxxxxx>
> Signed-off-by: Guo Weichao <guoweichao@xxxxxxxx>
> Reviewed-by: Chao Yu <yuchao0@xxxxxxxxxx>
> Signed-off-by: Jaegeuk Kim <jaegeuk@xxxxxxxxxx>

The test uses fallocate to preallocate the swap file and writes zeros to
it. I'm not sure what pin refers to?

--
Thank you,
Richard.