Re: [PATCH] Revert "pinctrl: intel: Split intel_pinctrl_add_padgroups() for better maintenance"

[Maximilian Luz]

On 3/8/21 5:42 PM, Andy Shevchenko wrote:
> On Mon, Mar 8, 2021 at 6:34 PM Maximilian Luz <luzmaximilian@xxxxxxxxx> wrote:
> > On 3/8/21 4:35 PM, Andy Shevchenko wrote:
> > > On Mon, Mar 08, 2021 at 04:25:05PM +0100, Maximilian Luz wrote:
> > > > Following commit 036e126c72eb ("pinctrl: intel: Split
> > > > intel_pinctrl_add_padgroups() for better maintenance"),
> > > > gpiochip_get_desc() is broken on some Kaby Lake R devices (specifically
> > > > a Microsoft Surface Book 2), returning -EINVAL for GPIOs that in reality
> > > > should be there (they are defined in ACPI and have been accessible
> > > > previously). Due to this, gpiod_get() fails with -ENOENT.
> > > >
> > > > Reverting this commit fixes that issue and the GPIOs in question are
> > > > accessible again.
> > >
> > > I would like to have more information.
> > > Can you enable PINCTRL and GPIO debug options in the kernel, and show dmesg
> > > output (when kernel command line has 'ignore_loglevel' option) for both working
> > > and non-working cases?
> >
> > Sure.
> >
> > Here are dmesg logs for:
> >
> >    - Kernel v5.12-rc2 (not working): https://paste.ubuntu.com/p/HVZybcvQDH/
>
> Thanks!
>
> Yeah, yeah... Please, test my patch, I am quite sure it will fix the issue.


It does indeed, thanks again!

Regards,
Max