Re: [PATCH] arch: x86: kernel: Adjust the words to suit sentences in the file vmlinux.lds.S

From: Randy Dunlap
Date: Tue Mar 09 2021 - 00:15:28 EST


On 3/8/21 7:41 PM, Bhaskar Chowdhury wrote:
>
>
> s/percpu/per CPU/
> s/baremetal/bare metal/
>
> Signed-off-by: Bhaskar Chowdhury <unixbhaskar@xxxxxxxxx>

Yeah, "bare metal" is a little better than "baremetal".

OTOH, "percpu" is a kernel construct's name. It doesn't have to
be proper English IMHO. (2 cents worth)

> ---
> arch/x86/kernel/vmlinux.lds.S | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/x86/kernel/vmlinux.lds.S b/arch/x86/kernel/vmlinux.lds.S
> index efd9e9ea17f2..592a44ad13b1 100644
> --- a/arch/x86/kernel/vmlinux.lds.S
> +++ b/arch/x86/kernel/vmlinux.lds.S
> @@ -217,7 +217,7 @@ SECTIONS
>
> #if defined(CONFIG_X86_64) && defined(CONFIG_SMP)
> /*
> - * percpu offsets are zero-based on SMP. PERCPU_VADDR() changes the
> + * per CPU offsets are zero-based on SMP. PERCPU_VADDR() changes the
> * output PHDR, so the next output section - .init.text - should
> * start another segment - init.
> */
> @@ -262,7 +262,7 @@ SECTIONS
> /*
> * start address and size of operations which during runtime
> * can be patched with virtualization friendly instructions or
> - * baremetal native ones. Think page table operations.
> + * bare metal native ones. Think page table operations.
> * Details in paravirt_types.h
> */
> . = ALIGN(8);
> --


--
~Randy