Re: [PATCH] clocksource: sh_cmt: use CMTOUT_IE only when supported

From: Wolfram Sang
Date: Tue Mar 09 2021 - 04:36:21 EST



> But given my comments below, I think it would make sense to change the
> one-line summary to e.g. "clocksource: sh_cmt: R-Car Gen2/Gen3 do not
> have CMTOUT_IE".

Makes sense. I will resend.

> SH_CMT_48BIT:
> sh73a0/r8a7740: CMTOUT_IE supported on channels 1/2/3, not on 0/4/5

Oh, I didn't spot this, sorry!

> So even not all older models support this bit.
> Probably this bit should only be set when the timer is configured as a
> wake-up source. But that is out-of-scope for this patch.

Ack.

Attachment: signature.asc
Description: PGP signature