Re: [PATCH v6 1/4] PM / devfreq: Register devfreq as a cooling device on demand

From: Chanwoo Choi
Date: Tue Mar 09 2021 - 04:52:27 EST


Hi,

On 3/8/21 10:30 PM, Daniel Lezcano wrote:
> Currently the default behavior is to manually having the devfreq
> backend to register themselves as a devfreq cooling device.
>
> Instead of adding the code in the drivers for the thermal cooling
> device registering, let's provide a flag in the devfreq's profile to
> tell the common devfreq code to register the newly created devfreq as
> a cooling device.
>
> Suggested-by: Chanwoo Choi <cwchoi00@xxxxxxxxx>
> Signed-off-by: Daniel Lezcano <daniel.lezcano@xxxxxxxxxx>
> Reviewed-by: Steven Price <steven.price@xxxxxxx>
> Reviewed-by: Lukasz Luba <lukasz.luba@xxxxxxx>
> ---
> V6:
> - Did one line string instead of multiline
> - Removed thermal.h header inclusion as it is in devfreq_cooling.h
> - Added forward declaration for thermal_cooling_device pointer in devfreq.h
> V5:
> - Changed subject prefix by: PM / devfreq
> V4:
> - Replaced thermal_cooling_device_unregister() by
> devfreq_cooling_unregister()
> V3:
> - Rebased on linux-pm branch without units.h
> - Set the cdev to NULL in case of error
> - Added description for the cdev field in the devfreq structure
> V2:
> - Added is_cooling_device boolean in profile structure
> - Register cooling device when the is_cooling_device boolean is set
> - Remove devfreq cooling device registration in the backend drivers
> V1:
> - Register devfreq as a cooling device unconditionnally
> ---
> drivers/devfreq/devfreq.c | 9 +++++++++
> include/linux/devfreq.h | 9 +++++++++
> 2 files changed, 18 insertions(+)

(snip)

Applied it. Thanks.

I made the pull request with immutable branch
for preventing the conflict on other git repo as following:

--
Best Regards,
Chanwoo Choi
Samsung Electronics


The following changes since commit fe07bfda2fb9cdef8a4d4008a409bb02f35f1bd8:

Linux 5.12-rc1 (2021-02-28 16:05:19 -0800)

are available in the Git repository at:

git://git.kernel.org/pub/scm/linux/kernel/git/chanwoo/linux.git immutable-devfreq-v5.13-rc1

for you to fetch changes up to 1224451bb6f938023dd7fa4e7ba43bfb185bc9e3:

PM / devfreq: Register devfreq as a cooling device on demand (2021-03-09 15:40:16 +0900)

----------------------------------------------------------------
Daniel Lezcano (1):
PM / devfreq: Register devfreq as a cooling device on demand

drivers/devfreq/devfreq.c | 9 +++++++++
include/linux/devfreq.h | 9 +++++++++
2 files changed, 18 insertions(+)