Re: [PATCH 02/11] PM / devfreq: remove the invalid description for get_target_freq

From: Dong Aisheng
Date: Tue Mar 09 2021 - 10:15:40 EST


On Tue, Mar 9, 2021 at 11:02 PM Chanwoo Choi <cwchoi00@xxxxxxxxx> wrote:
>
> On 21. 3. 9. 오후 9:58, Dong Aisheng wrote:
> > First of all, no_central_polling was removed since
> > commit 7e6fdd4bad03 ("PM / devfreq: Core updates to support devices
> > which can idle")
> > Secondly, get_target_freq() is not only called only with update_devfreq()
> > notified by OPP now, but also min/max freq qos notifier.
> >
> > So remove this invalid description now to avoid confusing.
> >
> > Signed-off-by: Dong Aisheng <aisheng.dong@xxxxxxx>
> > ---
> > drivers/devfreq/governor.h | 2 --
> > 1 file changed, 2 deletions(-)
> >
> > diff --git a/drivers/devfreq/governor.h b/drivers/devfreq/governor.h
> > index 70f44b3ca42e..5cee3f64fe2b 100644
> > --- a/drivers/devfreq/governor.h
> > +++ b/drivers/devfreq/governor.h
> > @@ -57,8 +57,6 @@
> > * Basically, get_target_freq will run
> > * devfreq_dev_profile.get_dev_status() to get the
> > * status of the device (load = busy_time / total_time).
> > - * If no_central_polling is set, this callback is called
> > - * only with update_devfreq() notified by OPP.
> > * @event_handler: Callback for devfreq core framework to notify events
> > * to governors. Events include per device governor
> > * init and exit, opp changes out of devfreq, suspend
> >
>
> As I replied from patch1, I recommend that squash it with patch1.

Got it, i will squash when sending the next version.
Thanks

Regards
Aisheng

>
> --
> Best Regards,
> Samsung Electronics
> Chanwoo Choi