Re: [PATCH] i2c: add i2c bus driver for amd navi gpu

From: kernel test robot
Date: Tue Mar 09 2021 - 10:38:18 EST


Hi Sanket,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on wsa/i2c/for-next]
[also build test WARNING on v5.12-rc2 next-20210309]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url: https://github.com/0day-ci/linux/commits/Sanket-Goswami/i2c-add-i2c-bus-driver-for-amd-navi-gpu/20210309-213535
base: https://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git i2c/for-next
config: riscv-randconfig-r003-20210309 (attached as .config)
compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project 820f508b08d7c94b2dd7847e9710d2bc36d3dd45)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install riscv cross compiling tool for clang build
# apt-get install binutils-riscv64-linux-gnu
# https://github.com/0day-ci/linux/commit/f1d0b9c128d45f6d55f3d3f864db2e7ebf42adc5
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Sanket-Goswami/i2c-add-i2c-bus-driver-for-amd-navi-gpu/20210309-213535
git checkout f1d0b9c128d45f6d55f3d3f864db2e7ebf42adc5
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=riscv

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>

All warnings (new ones prefixed by >>):

>> drivers/i2c/busses/i2c-designware-master.c:899:5: warning: no previous prototype for function 'amd_i2c_adap_quirk' [-Wmissing-prototypes]
int amd_i2c_adap_quirk(struct dw_i2c_dev *amdev)
^
drivers/i2c/busses/i2c-designware-master.c:899:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
int amd_i2c_adap_quirk(struct dw_i2c_dev *amdev)
^
static
1 warning generated.


vim +/amd_i2c_adap_quirk +899 drivers/i2c/busses/i2c-designware-master.c

898
> 899 int amd_i2c_adap_quirk(struct dw_i2c_dev *amdev)
900 {
901 struct i2c_adapter *amdap = &amdev->adapter;
902 int ret;
903
904 if (!(amdev->flags & AMD_NON_INTR_MODE))
905 return -ENODEV;
906
907 return i2c_add_numbered_adapter(amdap);
908
909 return ret;
910 }
911

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx

Attachment: .config.gz
Description: application/gzip