Re: [PATCH] greybus/operation: Drop reference when message has been set

From: Greg KH
Date: Wed Mar 10 2021 - 04:33:22 EST


On Wed, Mar 10, 2021 at 01:10:14AM -0800, Lv Yunlong wrote:
> In gb_operation_response_send, get an extra reference
> before gb_message_send() with this comment "/* Reference will
> be dropped when message has been sent. */". Therefore, we
> should drop the got reference not only in the error branch,
> but also in the complete branch.

That's not what your patch does at all :(