Re: [PATCH] i2c: i2c-scmi: Drop unused ACPI_MODULE_NAME definition

From: Rafael J. Wysocki
Date: Wed Mar 10 2021 - 09:48:27 EST


On Fri, Mar 5, 2021 at 7:29 PM Rafael J. Wysocki <rjw@xxxxxxxxxxxxx> wrote:
>
> From: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx>
>
> The ACPI_MODULE_NAME() definition is only used by the message
> printing macros from ACPICA that are not used by the code in
> question, so it is redundant. Drop it.
>
> No functional impact.
>
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx>

If there are no concerns regarding this, I'll queue it up for 5.13 in
the ACPI tree, thanks!

> ---
> drivers/i2c/busses/i2c-scmi.c | 2 --
> 1 file changed, 2 deletions(-)
>
> Index: linux-pm/drivers/i2c/busses/i2c-scmi.c
> ===================================================================
> --- linux-pm.orig/drivers/i2c/busses/i2c-scmi.c
> +++ linux-pm/drivers/i2c/busses/i2c-scmi.c
> @@ -18,8 +18,6 @@
> /* SMBUS HID definition as supported by Microsoft Windows */
> #define ACPI_SMBUS_MS_HID "SMB0001"
>
> -ACPI_MODULE_NAME("smbus_cmi");
> -
> struct smbus_methods_t {
> char *mt_info;
> char *mt_sbr;
>
>
>