Re: [PATCH 1/2] mips: syscalls: switch to generic syscalltbl.sh

From: Thomas Bogendoerfer
Date: Wed Mar 10 2021 - 10:19:44 EST


On Mon, Mar 01, 2021 at 11:48:24PM +0900, Masahiro Yamada wrote:
> Many architectures duplicate similar shell scripts.
>
> This commit converts mips to use scripts/syscalltbl.sh. This also
> unifies syscall_table_32_o32.h and syscall_table_64_o32.h into
> syscall_table_o32.h.
>
> The offset parameters are unneeded here; __SYSCALL(nr, entry) is defined
> as 'PTR entry', so the parameter 'nr' is not used in the first place.
>
> With this commit, syscall tables and generated files are straight
> mapped, which makes things easier to understand.
>
> syscall_n32.tbl --> syscall_table_n32.h
> syscall_n64.tbl --> syscall_table_n64.h
> syscall_o32.tbl --> syscall_table_o32.h
>
> Then, the abi parameters are also unneeded.
>
> Signed-off-by: Masahiro Yamada <masahiroy@xxxxxxxxxx>
> ---
>
> arch/mips/include/asm/Kbuild | 7 +++--
> arch/mips/kernel/scall32-o32.S | 4 +--
> arch/mips/kernel/scall64-n32.S | 3 +--
> arch/mips/kernel/scall64-n64.S | 3 +--
> arch/mips/kernel/scall64-o32.S | 4 +--
> arch/mips/kernel/syscalls/Makefile | 31 ++++++---------------
> arch/mips/kernel/syscalls/syscalltbl.sh | 36 -------------------------
> 7 files changed, 17 insertions(+), 71 deletions(-)
> delete mode 100644 arch/mips/kernel/syscalls/syscalltbl.sh

applied to mips-next.

Thomas.

--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]