Re: [PATCH 5.10 23/49] ACPI: video: Add DMI quirk for GIGABYTE GB-BXBT-2807

[Pavel Machek]

Hi!

On Wed 2021-03-10 14:23:34, gregkh@xxxxxxxxxxxxxxxxxxx wrote:
> From: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> 
> From: Jasper St. Pierre <jstpierre@xxxxxxxxxxx>

Something is funny with the From header here. But that's not main
thing -- this patch is evil.

> 
> [ Upstream commit 25417185e9b5ff90746d50769d2a3fcd1629e254 ]
> 
> The GIGABYTE GB-BXBT-2807 is a mini-PC which uses off the shelf
> components, like an Intel GPU which is meant for mobile systems.
> As such, it, by default, has a backlight controller exposed.
> 
> Unfortunately, the backlight controller only confuses userspace, which
> sees the existence of a backlight device node and has the unrealistic
> belief that there is actually a backlight there!
> 
> Add a DMI quirk to force the backlight off on this system.

> +++ b/drivers/acpi/video_detect.c
> @@ -140,6 +140,13 @@ static const struct dmi_system_id video_detect_dmi_table[] = {
>  	},
>  	{
>  	.callback = video_detect_force_vendor,
> +	.ident = "GIGABYTE GB-BXBT-2807",
> +	.matches = {
> +		DMI_MATCH(DMI_SYS_VENDOR, "GIGABYTE"),
> +		DMI_MATCH(DMI_PRODUCT_NAME, "GB-BXBT-2807"),
> +		},
> +	},
> +	{
>  	.ident = "Sony VPCEH3U1E",
>  	.matches = {
>  		DMI_MATCH(DMI_SYS_VENDOR, "Sony Corporation"),

Yup, and it looks like this fixes the problem for GIGABYTE
GB-BXBT-2807 but re-introduces the problem for Sony VPCEH3U1E, because
its .callback is now NULL.

Best regards,
								Pavel

IOW I'm suggesting this:

Signed-off-by: Pavel Machek (CIP) <pavel@xxxxxxx>

diff --git a/drivers/acpi/video_detect.c b/drivers/acpi/video_detect.c
index 811d298637cb..83cd4c95faf0 100644
--- a/drivers/acpi/video_detect.c
+++ b/drivers/acpi/video_detect.c
@@ -147,6 +147,7 @@ static const struct dmi_system_id video_detect_dmi_table[] = {
 		},
 	},
 	{
+	.callback = video_detect_force_vendor,
 	.ident = "Sony VPCEH3U1E",
 	.matches = {
 		DMI_MATCH(DMI_SYS_VENDOR, "Sony Corporation"),

-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

Attachment: signature.asc
Description: Digital signature