Re: [PATCH v2] mm: huge_memory: a new debugfs interface for splitting THP tests.

[Zi Yan]

On 10 Mar 2021, at 20:12, Yang Shi wrote:

> On Wed, Mar 10, 2021 at 7:36 AM Zi Yan <zi.yan@xxxxxxxx> wrote:
>>
>> From: Zi Yan <ziy@xxxxxxxxxx>
>>
>> We do not have a direct user interface of splitting the compound page
>> backing a THP and there is no need unless we want to expose the THP
>> implementation details to users. Adding an interface for debugging.
>>
>> By writing "<pid>,<vaddr_start>,<vaddr_end>" to
>> <debugfs>/split_huge_pages_in_range_pid, THPs within the given virtual
>
> Can we reuse the existing split_huge_page knob instead of creating a new one?
>
> Two knobs for splitting huge pages on debugging purpose seem
> overkilling to me IMHO. I'm wondering if we could check if a special
> value (e.g. 1 or -1) is written then split all THPs as split_huge_page
> knob does?
>
> I don't think this interface is used widely so the risk should be very
> low for breaking userspace.

Thanks for the suggestion.

I prefer a separate interface to keep input handling simpler. I am also
planning to enhance this interface later to enable splitting huge pages
to any lower order when Matthew Wilcox’s large page in page cache gets in,
so it is better to keep it separate from existing split_huge_pages.

—
Best Regards,
Yan Zi

Attachment: signature.asc
Description: OpenPGP digital signature