Re: [PATCH v3 2/4] mm: memcontrol: make page_memcg{_rcu} only applicable for non-kmem page

From: Shakeel Butt
Date: Thu Mar 11 2021 - 22:23:28 EST


On Tue, Mar 9, 2021 at 2:09 AM Muchun Song <songmuchun@xxxxxxxxxxxxx> wrote:
>
> We want to reuse the obj_cgroup APIs to charge the kmem pages.
> If we do that, we should store an object cgroup pointer to
> page->memcg_data for the kmem pages.
>
> Finally, page->memcg_data can have 3 different meanings.

replace 'can' with 'will'

Other than that I think Roman and Johannes have already given very
good feedback.