Re: [PATCH v6 1/2] dt-bindings: serial: Add rx-tx-swap to stm32-usart

From: Martin DEVERA
Date: Fri Mar 12 2021 - 10:06:13 EST


On 3/12/21 3:56 PM, Martin DEVERA wrote:
On 3/12/21 3:23 PM, Rob Herring wrote:
On Fri, 12 Mar 2021 11:27:12 +0100, Martin Devera wrote:
Add new rx-tx-swap property to allow for RX & TX pin swapping.

Signed-off-by: Martin Devera <devik@xxxxxxxxxx>
Acked-by: Fabrice Gasnier <fabrice.gasnier@xxxxxxxxxxx>
---
v6:
   - add version changelog
v5:
   - yaml fixes based on Rob Herring comments
     - add serial.yaml reference
     - move compatible from 'then' to 'if'
v3:
   - don't allow rx-tx-swap for st,stm32-uart (suggested
     by Fabrice Gasnier)
v2:
   - change st,swap to rx-tx-swap (suggested by Rob Herring)
---
  .../devicetree/bindings/serial/st,stm32-uart.yaml  | 29 ++++++++++++++--------
  1 file changed, 19 insertions(+), 10 deletions(-)

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:
./Documentation/devicetree/bindings/serial/st,stm32-uart.yaml:81:12: [warning] wrong indentation: expected 10 but found 11 (indentation)

dtschema/dtc warnings/errors:

See https://patchwork.ozlabs.org/patch/1451861

This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Yoy are right, there is one extra space. But for some reason the check doesn't
find it:
Argh... sorry, ignore it please. It seems I removed yamllint.
I see the error now.