Re: [PATCH RFCv2] mm/madvise: introduce MADV_POPULATE_(READ|WRITE) to prefault/prealloc memory

From: David Hildenbrand
Date: Mon Mar 15 2021 - 08:26:53 EST


On 15.03.21 13:22, Kirill A. Shutemov wrote:
On Mon, Mar 08, 2021 at 05:45:20PM +0100, David Hildenbrand wrote:
+ case -EHWPOISON: /* Skip over any poisoned pages. */
+ start += PAGE_SIZE;
+ continue;

Why is it good approach? It's not abvious to me.

My main motivation was to simplify return code handling. I don't want to return -EHWPOISON to user space and I don't want to convert it into something misleading like -ENOMEM or -EINVAL. So I decided to handle such stuff internally.

What would be you take on that?

--
Thanks,

David / dhildenb