Re: [PATCH] Rectify spelling and grammar

From: Hans Verkuil
Date: Tue Mar 16 2021 - 03:46:17 EST


Hi Xiaofeng Cao,

The patch is good, but scripts/checkpatch.pl complains about a mismatch:

WARNING: From:/Signed-off-by: email address mismatch: 'From: Xiaofeng Cao <cxfcosmos@xxxxxxxxx>' != 'Signed-off-by: Xiaofeng Cao
<caoxiaofeng@xxxxxxxxxx>'

Which is the one I should use?

Regards,

Hans

On 11/03/2021 08:20, Xiaofeng Cao wrote:
> Change 'inaccesable' to 'inaccessible'
> Change 'detrmine' to 'determine'
> Delete 'in' grammatically
>
> Signed-off-by: Xiaofeng Cao <caoxiaofeng@xxxxxxxxxx>
> ---
> drivers/media/radio/radio-si476x.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/media/radio/radio-si476x.c b/drivers/media/radio/radio-si476x.c
> index 23997425bdb5..b39a68f83c5f 100644
> --- a/drivers/media/radio/radio-si476x.c
> +++ b/drivers/media/radio/radio-si476x.c
> @@ -152,7 +152,7 @@ static struct v4l2_ctrl_config si476x_ctrls[] = {
>
> /*
> * SI476X during its station seeking(or tuning) process uses several
> - * parameters to detrmine if "the station" is valid:
> + * parameters to determine if "the station" is valid:
> *
> * - Signal's SNR(in dBuV) must be lower than
> * #V4L2_CID_SI476X_SNR_THRESHOLD
> @@ -255,7 +255,7 @@ struct si476x_radio;
> *
> * This table holds pointers to functions implementing particular
> * operations depending on the mode in which the tuner chip was
> - * configured to start in. If the function is not supported
> + * configured to start. If the function is not supported
> * corresponding element is set to #NULL.
> *
> * @tune_freq: Tune chip to a specific frequency
> @@ -917,7 +917,7 @@ static int si476x_radio_s_ctrl(struct v4l2_ctrl *ctrl)
> case V4L2_CID_RDS_RECEPTION:
> /*
> * It looks like RDS related properties are
> - * inaccesable when tuner is in AM mode, so cache the
> + * inaccessible when tuner is in AM mode, so cache the
> * changes
> */
> if (si476x_core_is_in_am_receiver_mode(radio->core))
>