RE: [PATCH 4/4] phy: cadence-torrent: Explicitly request exclusive reset control

From: Swapnil Kashinath Jakhade
Date: Thu Mar 18 2021 - 05:58:56 EST




> -----Original Message-----
> From: Kishon Vijay Abraham I <kishon@xxxxxx>
> Sent: Wednesday, March 10, 2021 9:25 PM
> To: Kishon Vijay Abraham I <kishon@xxxxxx>; Vinod Koul
> <vkoul@xxxxxxxxxx>; Rob Herring <robh+dt@xxxxxxxxxx>; Philipp Zabel
> <p.zabel@xxxxxxxxxxxxxx>; Swapnil Kashinath Jakhade
> <sjakhade@xxxxxxxxxxx>
> Cc: linux-kernel@xxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; Lokesh Vutla
> <lokeshvutla@xxxxxx>; linux-phy@xxxxxxxxxxxxxxxxxxx
> Subject: [PATCH 4/4] phy: cadence-torrent: Explicitly request exclusive reset
> control
>
> EXTERNAL MAIL
>
>
> No functional change. Since the reset controls obtained in
> Torrent is exclusively used by the Torrent device, use
> exclusive reset control request API calls.
>
> Signed-off-by: Kishon Vijay Abraham I <kishon@xxxxxx>
> ---
> drivers/phy/cadence/phy-cadence-torrent.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>

Reviewed-by: Swapnil Jakhade <sjakhade@xxxxxxxxxxx>

Thanks & regards,
Swapnil

> diff --git a/drivers/phy/cadence/phy-cadence-torrent.c
> b/drivers/phy/cadence/phy-cadence-torrent.c
> index 5ee1657f5a1c..ff8bb4b724c0 100644
> --- a/drivers/phy/cadence/phy-cadence-torrent.c
> +++ b/drivers/phy/cadence/phy-cadence-torrent.c
> @@ -2264,7 +2264,7 @@ static int cdns_torrent_reset(struct
> cdns_torrent_phy *cdns_phy)
> return PTR_ERR(cdns_phy->phy_rst);
> }
>
> - cdns_phy->apb_rst = devm_reset_control_get_optional(dev,
> "torrent_apb");
> + cdns_phy->apb_rst =
> devm_reset_control_get_optional_exclusive(dev, "torrent_apb");
> if (IS_ERR(cdns_phy->apb_rst)) {
> dev_err(dev, "%s: failed to get apb reset\n",
> dev->of_node->full_name);
> --
> 2.17.1