Re: [PATCH v16 1/2] drm/tegra: dc: Support memory bandwidth management

From: Dmitry Osipenko
Date: Thu Mar 18 2021 - 06:34:18 EST


18.03.2021 12:31, Michał Mirosław пишет:
>> static const struct tegra_windowgroup_soc tegra194_dc_wgrps[] = {
>> @@ -2430,6 +2781,7 @@ static const struct tegra_dc_soc_info tegra194_dc_soc_info = {
>> .has_nvdisplay = true,
>> .wgrps = tegra194_dc_wgrps,
>> .num_wgrps = ARRAY_SIZE(tegra194_dc_wgrps),
>> + .plane_tiled_memory_bandwidth_x2 = false,
>> };
> For globals you will have .x = false by default; I'm not sure those entries
> add much value.
>
> Reviewed-by: Michał Mirosław <mirq-linux@xxxxxxxxxxxx>

IIRC, in the past Thierry preferred to add the defaults to this driver
in order to ease reading/understanding of the code. So I added them for
consistency.

Thank you very much for helping with the review!