Re: [PATCH v6 2/6] init_on_alloc: Optimize static branches

From: Vlastimil Babka
Date: Thu Mar 18 2021 - 08:47:36 EST


On 3/15/21 7:02 PM, Kees Cook wrote:
> The state of CONFIG_INIT_ON_ALLOC_DEFAULT_ON (and ...ON_FREE...) did not
> change the assembly ordering of the static branches: they were always out
> of line. Use the new jump_label macros to check the CONFIG settings to
> default to the "expected" state, which slightly optimizes the resulting
> assembly code.
>
> Reviewed-by: Alexander Potapenko <glider@xxxxxxxxxx>
> Link: https://lore.kernel.org/lkml/CAG_fn=X0DVwqLaHJTO6Jw7TGcMSm77GKHinrd0m_6y0SzWOrFA@xxxxxxxxxxxxxx/
> Signed-off-by: Kees Cook <keescook@xxxxxxxxxxxx>

For the fixed version

Acked-by: Vlastimil Babka <vbabka@xxxxxxx>