Re: [PATCH] Documentation: arm64/acpi : clarify arm64 support of IBFT

From: Ard Biesheuvel
Date: Thu Mar 18 2021 - 10:21:54 EST


On Thu, 18 Mar 2021 at 12:29, Lorenzo Pieralisi
<lorenzo.pieralisi@xxxxxxx> wrote:
>
> [+ Al, Ard]
>
> On Thu, Mar 18, 2021 at 10:44:33AM +0000, Will Deacon wrote:
> > [+Lorenzo]
> >
> > On Tue, Mar 16, 2021 at 12:50:41PM -0600, Tom Saeger wrote:
> > > In commit 94bccc340710 ("iscsi_ibft: make ISCSI_IBFT dependson ACPI instead
> > > of ISCSI_IBFT_FIND") Kconfig was disentangled to make ISCSI_IBFT selection
> > > not depend on x86.
> > >
> > > Update arm64 acpi documentation, changing IBFT support status from
> > > "Not Supported" to "Optional".
> > > Opportunistically re-flow paragraph for changed lines.
> > >
> > > Link: https://lore.kernel.org/lkml/1563475054-10680-1-git-send-email-thomas.tai@xxxxxxxxxx/
> > >
> > > Signed-off-by: Tom Saeger <tom.saeger@xxxxxxxxxx>
> > > ---
> > > Documentation/arm64/acpi_object_usage.rst | 10 +++++-----
> > > 1 file changed, 5 insertions(+), 5 deletions(-)
> >
> > Lorenzo, please could you ack the change below if you're happy with it?
> > If so, I can take it as a fix.
>
> I don't see any issue with this patch, more so given that the IBFT
> legacy discovery method was decoupled from the ACPI table method,
> so it looks sound on ARM64.
>
> However, I would like to get Al and Ard opinions on this to make sure
> there is not something I am missing (in particular wrt the rationale
> behind the "Not Supported" in the docs).
>

Both the original change and this documentation change look fine to me.

Acked-by: Ard Biesheuvel <ardb@xxxxxxxxxx>