Re: linux-next: Tree for Mar 16 (AD9467 & ADI_AXI_ADC)

From: Randy Dunlap
Date: Thu Mar 18 2021 - 14:46:26 EST


On 3/17/21 1:16 AM, Alexandru Ardelean wrote:
> On Tue, Mar 16, 2021 at 11:20 PM Randy Dunlap <rdunlap@xxxxxxxxxxxxx> wrote:
>>
>> On 3/15/21 9:50 PM, Stephen Rothwell wrote:
>>> Hi all,
>>>
>>> News: there will be no linux-next release on Friday this week.
>>>
>>> Warning: Some of the branches in linux-next are still based on v5.12-rc1,
>>> so please be careful if you are trying to bisect a bug.
>>>
>>> News: if your -next included tree is based on Linus' tree tag
>>> v5.12-rc1{,-dontuse} (or somewhere between v5.11 and that tag), please
>>> consider rebasing it onto v5.12-rc2. Also, please check any branches
>>> merged into your branch.
>>>
>>> Changes since 20210315:
>>
>>
>> on i386 or x86_64:
>>
>> WARNING: unmet direct dependencies detected for ADI_AXI_ADC
>> Depends on [n]: IIO [=y] && HAS_IOMEM [=y] && OF [=n]
>> Selected by [y]:
>> - AD9467 [=y] && IIO [=y] && SPI [=y]
>>
>>
>> AD9467 should not select ADI_AXI_ADC when OF is not enabled,
>> so possibly AD9467 should depend on OF.
>
> Hmm, this becomes a bit complicated.
> We got here because we needed to add a depends on HAS_IOMEM for the
> ADI_AXI_ADC (due to the s390 arch).
> Maybe a better fix would be for AD9467 to depend on ADI_AXI_ADC.
> The AD9467 driver can't function without the ADI_AXI_ADC driver.

Yes, "depends on" works here. Please go ahead with that change.
Thanks.

> It is a little early to move this to a "high-speed ADC" subgroup.
>
>>
>>
>> Full randconfig file is attached.
>>
>>
>> --
>> ~Randy
>> Reported-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>


--
~Randy