Re: [PATCH] futex: use wake_up_process() instead of wake_up_state()

From: Mike Galbraith
Date: Fri Mar 19 2021 - 01:22:57 EST


On Fri, 2021-03-19 at 10:59 +0800, Wang Qing wrote:
> Using wake_up_process() is more simpler and friendly,
> and it is more convenient for analysis and statistics

I likely needn't bother, and don't have a NAK to paste on this thing,
but here's another copy of my NOPE for yet another gratuitous change
with complete BS justification.

>
> Signed-off-by: Wang Qing <wangqing@xxxxxxxx>
> ---
> kernel/futex.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/futex.c b/kernel/futex.c
> index e68db77..078a1f9
> --- a/kernel/futex.c
> +++ b/kernel/futex.c
> @@ -1820,7 +1820,7 @@ void requeue_pi_wake_futex(struct futex_q *q, union futex_key *key,
>
> q->lock_ptr = &hb->lock;
>
> - wake_up_state(q->task, TASK_NORMAL);
> + wake_up_process(q->task);
> }
>
> /**