Re: [PATCH v2 05/14] objtool: Per arch retpoline naming

From: Peter Zijlstra
Date: Fri Mar 19 2021 - 05:08:20 EST


On Thu, Mar 18, 2021 at 09:38:14PM -0500, Josh Poimboeuf wrote:
> On Thu, Mar 18, 2021 at 06:11:08PM +0100, Peter Zijlstra wrote:
> > @@ -872,7 +877,7 @@ static int add_jump_destinations(struct
> > } else if (reloc->sym->type == STT_SECTION) {
> > dest_sec = reloc->sym->sec;
> > dest_off = arch_dest_reloc_offset(reloc->addend);
> > - } else if (!strncmp(reloc->sym->name, "__x86_indirect_thunk_", 21)) {
> > + } else if (arch_is_retpoline(reloc->sym)) {
> > /*
> > * Retpoline jumps are really dynamic jumps in
> > * disguise, so convert them accordingly.
>
> There's another one in add_call_destinations().

Bah, I'm sure I converted all of them at some point, must've lost a hunk
somewhere along the way. Fixed!