Re: [PATCH net-next 2/4] gro: add combined call_gro_receive() + INDIRECT_CALL_INET() helper
From: Alexander Lobakin
Date: Fri Mar 19 2021 - 07:14:08 EST
From: Paolo Abeni <pabeni@xxxxxxxxxx>
Date: Fri, 19 Mar 2021 11:53:42 +0100
> Hello,
Hi!
> On Thu, 2021-03-18 at 18:42 +0000, Alexander Lobakin wrote:
> > call_gro_receive() is used to limit GRO recursion, but it works only
> > with callback pointers.
> > There's a combined version of call_gro_receive() + INDIRECT_CALL_2()
> > in <net/inet_common.h>, but it doesn't check for IPv6 modularity.
>
> AFAICS, ip6_offload is builtin even when IPv6 is a module, so the above
> should not be needed.
Aww, you are right. I overlooked that since dev_gro_receive() still
use INDIRECT_CALL_INET(), though all GRO callbacks were made
built-in.
Seems like more code can be optimized, thanks!
> Cheers,
>
> Paolo
Al