Re: [PATCH v11 1/9] drivers: thermal: tsens: Add VER_0 tsens version

From: Thara Gopinath
Date: Fri Mar 19 2021 - 10:12:25 EST




On 3/19/21 9:28 AM, Ansuel Smith wrote:
On Fri, Mar 19, 2021 at 09:11:38AM -0400, Thara Gopinath wrote:


On 3/18/21 8:52 PM, Ansuel Smith wrote:
VER_0 is used to describe device based on tsens version before v0.1.
These device are devices based on msm8960 for example apq8064 or
ipq806x.

Hi Ansuel,

There are still checkpatch check warnings in this patch. Please run
checkpatch.pl --strict and fix them. Once that is done, you can add

Reviewed-by: Thara Gopinath <thara.gopinath@xxxxxxxxxx>

Warm Regards
Thara


Hi,
thanks a lot for the review. The only warning I have is a line ending
with ( that i think I can't fix or I will go over the max char for line.
Do you have something more?

I see two warning for line ending with (. The max char limit is 100.

--
Warm Regards
Thara