[PATCH v5 4/7] mm: memcontrol: change ug->dummy_page only if memcg changed

From: Muchun Song
Date: Fri Mar 19 2021 - 12:39:37 EST


Just like assignment to ug->memcg, we only need to update ug->dummy_page
if memcg changed. So move it to there. This is a very small optimization.

Signed-off-by: Muchun Song <songmuchun@xxxxxxxxxxxxx>
Acked-by: Johannes Weiner <hannes@xxxxxxxxxxx>
Reviewed-by: Shakeel Butt <shakeelb@xxxxxxxxxx>
---
mm/memcontrol.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mm/memcontrol.c b/mm/memcontrol.c
index 9489c7fc1e04..8d28a5a2ee58 100644
--- a/mm/memcontrol.c
+++ b/mm/memcontrol.c
@@ -6854,6 +6854,7 @@ static void uncharge_page(struct page *page, struct uncharge_gather *ug)
uncharge_gather_clear(ug);
}
ug->memcg = page_memcg(page);
+ ug->dummy_page = page;

/* pairs with css_put in uncharge_batch */
css_get(&ug->memcg->css);
@@ -6867,7 +6868,6 @@ static void uncharge_page(struct page *page, struct uncharge_gather *ug)
else
ug->pgpgout++;

- ug->dummy_page = page;
page->memcg_data = 0;
css_put(&ug->memcg->css);
}
--
2.11.0