RE: [PATCH v4] x86/Hyper-V: Support for free page reporting

From: Sunil Muthuswamy
Date: Fri Mar 19 2021 - 17:21:27 EST


> What's the strategy for this flag in the unlikely event that the hypercall fails?
> It doesn't seem right to have hv_query_ext_cap() fail, but leave the
> static flag set to true. Just move that line down to after the status check
> has succeeded?

That call should not fail in any normal circumstances. The current idea was to
avoid repeating the same call on persistent failure. But, since we don't expect
the query capability to be called in any kind of hot path, I am ok moving this
down.

>
> Other than the above about the flag when the hypercall fails,
> everything else looks good.
Thanks for the review.