Re: [PATCH v3][next] xfs: Replace one-element arrays with flexible-array members

From: Gustavo A. R. Silva
Date: Sat Mar 20 2021 - 17:44:25 EST




On 3/20/21 15:17, Darrick J. Wong wrote:
>>>> Below are the results of running xfstests for groups shutdown and log
>>>> with the following configuration in local.config:
>>>>
>>>> export TEST_DEV=/dev/sda3
>>>> export TEST_DIR=/mnt/test
>>>> export SCRATCH_DEV=/dev/sda4
>>>> export SCRATCH_MNT=/mnt/scratch
>>>>
>>>> The size for both partitions /dev/sda3 and /dev/sda4 is 25GB.
>>>
>>> Looks good to me, will toss it at my fstests cloud and see if anything
>>> shakes out. Thanks for cleaning up this goofy thorn-pile!
>>
>> Great. It's been fun to work on this. :p
>
> Did you run the /entire/ fstests suite? With this patch applied to
> 5.12-rc2, I keep seeing list corruption assertions about an hour into

Nope; I run xfstests 'shutdown' and 'log' groups on 5.11.0, only.

How do you run the entire fstests?
Could you give me some pointers?

> the test run, and usually on some test that heavily exercises allocating
> and deleting file extents. I'll try to look at this patch more closely
> next week, but I figured I should let you know early, on the off chance
> something sticks out to you.

OK. I'll go run my tests on 5.12-rc2.

Should I run the entire xfstests, too?

Thanks
--
Gustavo