Re: [PATCH] net: make unregister netdev warning timeout configurable

From: Leon Romanovsky
Date: Sun Mar 21 2021 - 04:52:10 EST


On Sat, Mar 20, 2021 at 03:28:51PM +0100, Dmitry Vyukov wrote:
> netdev_wait_allrefs() issues a warning if refcount does not drop to 0
> after 10 seconds. While 10 second wait generally should not happen
> under normal workload in normal environment, it seems to fire falsely
> very often during fuzzing and/or in qemu emulation (~10x slower).
> At least it's not possible to understand if it's really a false
> positive or not. Automated testing generally bumps all timeouts
> to very high values to avoid flake failures.
> Make the timeout configurable for automated testing systems.
> Lowering the timeout may also be useful for e.g. manual bisection.
> The default value matches the current behavior.
>
> Signed-off-by: Dmitry Vyukov <dvyukov@xxxxxxxxxx>
> Fixes: https://bugzilla.kernel.org/show_bug.cgi?id=211877
> Cc: netdev@xxxxxxxxxxxxxxx
> Cc: linux-kernel@xxxxxxxxxxxxxxx
> ---
> net/Kconfig | 12 ++++++++++++
> net/core/dev.c | 4 +++-
> 2 files changed, 15 insertions(+), 1 deletion(-)
>

Our verification team would like to see this change too.

Thanks,
Reviewed-by: Leon Romanovsky <leonro@xxxxxxxxxx>