Re: [PATCH v6 1/2] dt-bindings: Add doc for FriendlyARM NanoPi R4S

[Heiko Stuebner]

Hi,

Am Freitag, 19. März 2021, 06:16:26 CET schrieb Tianling Shen:
> Add devicetree binding documentation for the FriendlyARM NanoPi R4S.
> 
> Changes in v6:
> - Fixed format of LED nodes
> 
> Changes in v5:
> - Dropped the empty PCIe node
> - Dropped useless `/delete-property/`
> - Renamed LED nodes
> 
> Changes in v4:
> - Correctly dropped `display-subsystem` node
> - Dropped meaningless `pwm-fan` node
> - Dropped wrong `sdmmc` node
> - Disabled `i2c4` and `uart0` as they don't exist in the design
> - Format fixes
> 
> Changes in v3:
> - Dropped non-existent node `display_subsystem`
> 
> Changes in v2:
> - Disable display for NanoPi R4S (reference commit: 74532de460ec)
> - Light "sys" LED on NanoPi R4S (reference commit: 833821eeab91)
> 
> Signed-off-by: Tianling Shen <cnsztl@xxxxxxxxx>

In v4 you received a
Acked-by: Rob Herring <robh@xxxxxxxxxx>

Please pick these up and carry them over into new versions
of your patchset. Otherwise Rob would needlessly review
things multiple times.


Heiko

> ---
>  Documentation/devicetree/bindings/arm/rockchip.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml
> index c3036f95c7bc..4a6f772c1043 100644
> --- a/Documentation/devicetree/bindings/arm/rockchip.yaml
> +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml
> @@ -134,6 +134,7 @@ properties:
>                - friendlyarm,nanopi-m4
>                - friendlyarm,nanopi-m4b
>                - friendlyarm,nanopi-neo4
> +              - friendlyarm,nanopi-r4s
>            - const: rockchip,rk3399
>  
>        - description: GeekBuying GeekBox
>