[PATCH 2/2] scsi: myrb: fix null-ptr-dereference in myrb_probe

From: Tong Zhang
Date: Sun Mar 21 2021 - 20:30:51 EST


cb->host should be initialized and set before it is used by the
following probe logic and the interrupt handler etc.

[ 5.073493] BUG: kernel NULL pointer dereference, address: 00000000000002cc
[ 5.075907] RIP: 0010:kobject_put+0x25/0x120
[ 5.081572] Call Trace:
[ 5.081720] myrb_probe.cold+0x22/0xabc [myrb]
[ 5.083510] local_pci_probe+0x6f/0xb0

Fixes: 081ff398c56c ("scsi: myrb: Add Mylex RAID controller (block interface)")
Signed-off-by: Tong Zhang <ztong0001@xxxxxxxxx>
---
drivers/scsi/myrb.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/scsi/myrb.c b/drivers/scsi/myrb.c
index ee33d97fb92c..7de49b869128 100644
--- a/drivers/scsi/myrb.c
+++ b/drivers/scsi/myrb.c
@@ -3512,6 +3512,7 @@ static struct myrb_hba *myrb_detect(struct pci_dev *pdev,
shost->max_cmd_len = 12;
shost->max_lun = 256;
cb = shost_priv(shost);
+ cb->host = shost;
mutex_init(&cb->dcmd_mutex);
mutex_init(&cb->dma_mutex);
cb->pdev = pdev;
--
2.25.1