Re: [PATCH v2] MIPS/bpf: Enable bpf_probe_read{, str}() on MIPS again

From: Christoph Hellwig
Date: Mon Mar 22 2021 - 03:13:29 EST


On Mon, Mar 22, 2021 at 05:46:56AM +0100, Maciej W. Rozycki wrote:
> On Thu, 18 Mar 2021, Tiezhu Yang wrote:
>
> > diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig
> > index 160b3a8..4b94ec7 100644
> > --- a/arch/mips/Kconfig
> > +++ b/arch/mips/Kconfig
> > @@ -6,6 +6,7 @@ config MIPS
> > select ARCH_BINFMT_ELF_STATE if MIPS_FP_SUPPORT
> > select ARCH_HAS_FORTIFY_SOURCE
> > select ARCH_HAS_KCOV
> > + select ARCH_HAS_NON_OVERLAPPING_ADDRESS_SPACE
>
> Hmm, documentation on ARCH_HAS_NON_OVERLAPPING_ADDRESS_SPACE seems rather
> scarce, but based on my guess shouldn't this be "if !EVA"?

ARCH_HAS_NON_OVERLAPPING_ADDRESS_SPACE means the any given virtual
address in a task context can either be a valid kernel or user address
space, but not both.

Note that the bpf probe really is a legacy use case and should not be
used in new code independent of that.