Re: [PATCH] thermal/drivers/cpuidle_cooling: Fix use after error

From: Viresh Kumar
Date: Mon Mar 22 2021 - 04:13:05 EST


On 22-03-21, 09:08, Daniel Lezcano wrote:
> On 22/03/2021 04:29, Viresh Kumar wrote:
> > On 19-03-21, 21:25, Daniel Lezcano wrote:
> >> When the function successfully finishes it logs an information about
> >> the registration of the cooling device and use its name to build the
> >> message. Unfortunately it was freed right before:
> >>
> >> drivers/thermal/cpuidle_cooling.c:218 __cpuidle_cooling_register()
> >> warn: 'name' was already freed.
> >>
> >> Fix this by freeing after the message happened.
> >>
> >> Fixes: 6fd1b186d900 ("thermal/drivers/cpuidle_cooling: Use device name instead of auto-numbering")
> >
> > Why not merge this with the Fixes patch itself since it isn't there in Linus's
> > tree yet ?
> >
> > Or is your branch strictly immutable ?
>
> Hi Viresh;
>
> The changes follow the path:
>
> testing -> linux-next -> next
>
> The branch next is never rebased. The patch above reached it. This is
> notified by the thermal-bot [1].

Ahh, I see.

Here you go :)

Acked-by: Viresh Kumar <viresh.kumar@xxxxxxxxxx>

--
viresh