Re: [PATCH] arm64: dts: qcom: sc7280: Add PMIC peripherals for SC7280

[skakit]

Hi Bjorn,

On 2021-03-12 23:06, Bjorn Andersson wrote:
> On Thu 11 Mar 04:40 CST 2021, satya priya wrote:
>
> > Add PM7325/PM8350C/PMK8350/PMR735A peripherals such as PON,
> > GPIOs, RTC and other PMIC infra modules for SC7280.
>
> Overall this looks good, just two small things below.
>
> > Signed-off-by: satya priya <skakit@xxxxxxxxxxxxxx>
> > ---
> > This patch depends on base DT and board files for SC7280 to merge 
> > first
> > https://lore.kernel.org/patchwork/project/lkml/list/?series=487403
> >
> >  arch/arm64/boot/dts/qcom/pm7325.dtsi  |  60 ++++++++++++++++++++
> >  arch/arm64/boot/dts/qcom/pm8350c.dtsi |  60 ++++++++++++++++++++
> >  arch/arm64/boot/dts/qcom/pmk8350.dtsi | 104 
> > ++++++++++++++++++++++++++++++++++
> >  arch/arm64/boot/dts/qcom/pmr735a.dtsi |  60 ++++++++++++++++++++
> >  arch/arm64/boot/dts/qcom/sc7280.dtsi  |   8 +++
> >  5 files changed, 292 insertions(+)
> >  create mode 100644 arch/arm64/boot/dts/qcom/pm7325.dtsi
> >  create mode 100644 arch/arm64/boot/dts/qcom/pm8350c.dtsi
> >  create mode 100644 arch/arm64/boot/dts/qcom/pmk8350.dtsi
> >  create mode 100644 arch/arm64/boot/dts/qcom/pmr735a.dtsi
> >
> > diff --git a/arch/arm64/boot/dts/qcom/pm7325.dtsi 
> > b/arch/arm64/boot/dts/qcom/pm7325.dtsi
> > new file mode 100644
> > index 0000000..393b256
> > --- /dev/null
> > +++ b/arch/arm64/boot/dts/qcom/pm7325.dtsi
> > @@ -0,0 +1,60 @@
> > +// SPDX-License-Identifier: BSD-3-Clause
> > +// Copyright (c) 2021, The Linux Foundation. All rights reserved.
> > +
> > +#include <dt-bindings/interrupt-controller/irq.h>
> > +#include <dt-bindings/spmi/spmi.h>
> > +
> > +&spmi_bus {
> > +	pm7325: pmic@1 {
> > +		compatible = "qcom,pm7325", "qcom,spmi-pmic";
> > +		reg = <0x1 SPMI_USID>;
> > +		#address-cells = <1>;
> > +		#size-cells = <0>;
> > +
> > +		pm7325_tz: temp-alarm@a00 {
> > +			compatible = "qcom,spmi-temp-alarm";
> > +			reg = <0xa00>;
> > +			interrupts = <0x1 0xa 0x0 IRQ_TYPE_EDGE_BOTH>;
> > +			#thermal-sensor-cells = <0>;
> > +		};
> > +
> > +		pm7325_gpios: gpios@8800 {
> > +			compatible = "qcom,pm7325-gpio", "qcom,spmi-gpio";
> > +			reg = <0x8800>;
> > +			gpio-controller;
> > +			gpio-ranges = <&pm7325_gpios 0 0 10>;
> > +			#gpio-cells = <2>;
> > +			interrupt-controller;
> > +			#interrupt-cells = <2>;
> > +		};
> > +	};
> > +};
> > +
> > +&thermal_zones {
> > +	pm7325_temp_alarm: pm7325_tz {
>
> '_' is not allowed to be used in node names, there's a few of these
> sprinkled through the patch. Please replace them with '-'.

Okay, will replace them.

> > +		polling-delay-passive = <100>;
> > +		polling-delay = <0>;
> > +		thermal-governor = "step_wise";
> > +		thermal-sensors = <&pm7325_tz>;
> > +
> > +		trips {
> > +			pm7325_trip0: trip0 {
> > +				temperature = <95000>;
> > +				hysteresis = <0>;
> > +				type = "passive";
> > +			};
> > +
> > +			pm7325_trip1: trip1 {
> > +				temperature = <115000>;
> > +				hysteresis = <0>;
> > +				type = "critical";
> > +			};
> > +
> > +			pm7325_trip2: trip2 {
> > +				temperature = <145000>;
> > +				hysteresis = <0>;
> > +				type = "critical";
> > +			};
> > +		};
> > +	};
> > +};
> [..]
> > diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi 
> > b/arch/arm64/boot/dts/qcom/sc7280.dtsi
> > index 8af6d77..25402d4 100644
> > --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi
> > +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi
> > @@ -606,4 +606,12 @@
> >  			     <GIC_PPI 11 IRQ_TYPE_LEVEL_LOW>,
> >  			     <GIC_PPI 10 IRQ_TYPE_LEVEL_LOW>;
> >  	};
> > +
> > +	thermal_zones: thermal-zones {
> > +	};
> >  };
> > +
> > +#include "pm7325.dtsi"
> > +#include "pm8350c.dtsi"
> > +#include "pmk8350.dtsi"
> > +#include "pmr735a.dtsi"
>
> Is there any particular reason for you including these at the end of
> sc7270.dtsi, rather than the top like we do in other platforms?
>
> Also, are all SC7280 devices always coming with this quartet? We've 
> seen
> variations of this in the past and therefor typically include them from
> the board dts instead.

No specific reason, will add them in board dts file.

> Regards,
> Bjorn

Thanks,
Satya Priya