RE: [EXT] [PATCH] scsi: qedi: fix error return code of qedi_alloc_global_queues()

[Manish Rangankar]

> -----Original Message-----
> From: Jia-Ju Bai <baijiaju1990@xxxxxxxxx>
> Sent: Monday, March 8, 2021 9:00 AM
> To: Nilesh Javali <njavali@xxxxxxxxxxx>; Manish Rangankar
> <mrangankar@xxxxxxxxxxx>; jejb@xxxxxxxxxxxxx;
> martin.petersen@xxxxxxxxxx
> Cc: GR-QLogic-Storage-Upstream <GR-QLogic-Storage-
> Upstream@xxxxxxxxxxx>; linux-scsi@xxxxxxxxxxxxxxx; linux-
> kernel@xxxxxxxxxxxxxxx; Jia-Ju Bai <baijiaju1990@xxxxxxxxx>
> Subject: [EXT] [PATCH] scsi: qedi: fix error return code of
> qedi_alloc_global_queues()
> 
> External Email
> 
> ----------------------------------------------------------------------
> When kzalloc() returns NULL to qedi->global_queues[i], no error return code of
> qedi_alloc_global_queues() is assigned.
> To fix this bug, status is assigned with -ENOMEM in this case.
> 
> Fixes: ace7f46ba5fd ("scsi: qedi: Add QLogic FastLinQ offload iSCSI driver
> framework.")
> Reported-by: TOTE Robot <oslab@xxxxxxxxxxxxxxx>
> Signed-off-by: Jia-Ju Bai <baijiaju1990@xxxxxxxxx>
> ---
>  drivers/scsi/qedi/qedi_main.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/scsi/qedi/qedi_main.c b/drivers/scsi/qedi/qedi_main.c index
> 47ad64b06623..69c5b5ee2169 100644
> --- a/drivers/scsi/qedi/qedi_main.c
> +++ b/drivers/scsi/qedi/qedi_main.c
> @@ -1675,6 +1675,7 @@ static int qedi_alloc_global_queues(struct qedi_ctx
> *qedi)
>  		if (!qedi->global_queues[i]) {
>  			QEDI_ERR(&qedi->dbg_ctx,
>  				 "Unable to allocation global queue %d.\n", i);
> +			status = -ENOMEM;
>  			goto mem_alloc_failure;
>  		}
> 
> --
> 2.17.1

Thanks,
Acked-by: Manish Rangankar <mrangankar@xxxxxxxxxxx>