[PATCH v2 8/8] USB: cdc-acm: do not log successful probe on later errors

From: Johan Hovold
Date: Mon Mar 22 2021 - 11:54:19 EST


Do not log the successful-probe message until the tty device has been
registered.

Signed-off-by: Johan Hovold <johan@xxxxxxxxxx>
---
drivers/usb/class/cdc-acm.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/usb/class/cdc-acm.c b/drivers/usb/class/cdc-acm.c
index 914486d0f68c..337ffced9c40 100644
--- a/drivers/usb/class/cdc-acm.c
+++ b/drivers/usb/class/cdc-acm.c
@@ -1473,8 +1473,6 @@ static int acm_probe(struct usb_interface *intf,
acm->nb_index = 0;
acm->nb_size = 0;

- dev_info(&intf->dev, "ttyACM%d: USB ACM device\n", minor);
-
acm->line.dwDTERate = cpu_to_le32(9600);
acm->line.bDataBits = 8;
acm_set_line(acm, &acm->line);
@@ -1497,6 +1495,8 @@ static int acm_probe(struct usb_interface *intf,
usb_clear_halt(usb_dev, acm->out);
}

+ dev_info(&intf->dev, "ttyACM%d: USB ACM device\n", minor);
+
return 0;

err_release_data_interface:
--
2.26.3