Re: [PATCH] audit: avoid -Wempty-body warning

From: Arnd Bergmann
Date: Mon Mar 22 2021 - 12:28:56 EST


On Mon, Mar 22, 2021 at 3:33 PM Richard Guy Briggs <rgb@xxxxxxxxxx> wrote:

> > Change the macros to use the usual "do { } while (0)" instead, and change a
> > few more that were (void)0, for consistency.
>
> So what about audit_put_watch() and audit_get_watch() which are set to
> {}? (And all of include/linux/audit.h that uses the latter...) Does
> this only matter if they are the only action called in an if or loop?
>

I missed those, thanks for pointing it out. I sent a v2 patch now.

Arnd