Re: [PATCH v2 2/2] arm64: dts: qcom: sm8350: Add thermal zones and throttling support

[Konrad Dybcio]

Hi!


> +		tsens0: thermal-sensor@c222000 {
> +			compatible = "qcom,sm8350-tsens", "qcom,tsens-v2";
> +			reg = <0 0x0C263000 0 0x1ff>, /* TM */
> +			      <0 0x0C222000 0 0x8>; /* SROT */

Please use lowercase hex


> +		tsens1: thermal-sensor@c223000 {
> +			compatible = "qcom,sm8350-tsens", "qcom,tsens-v2";
> +			reg = <0 0x0C265000 0 0x1ff>, /* TM */
> +			      <0 0x0c223000 0 0x8>; /* SROT */

Ditto


> +			trips {
> +				cpu0_alert0: trip-point0 {
> +					temperature = <90000>;
> +					hysteresis = <2000>;
> +					type = "passive";
> +				};
> +
> +				cpu0_alert1: trip-point1 {
> +					temperature = <95000>;
> +					hysteresis = <2000>;
> +					type = "passive";

Shouldn't this be "hot"? Possibly ditto for all cpu*alert1-labeled nodes.


> +				};
> +
> +				cpu0_crit: cpu_crit {
> +					temperature = <110000>;
> +					hysteresis = <1000>;
> +					type = "critical";
> +				};
> +			};

These values seem, err.. scorching hot.. Are they alright?



> +		// TODO: What is the NSP subsystem?
Please use C-style comments (/* foo */)

	


Konrad