Re: [PATCH 04/17] auxdisplay: img-ascii-lcd: Add helper variable dev

[Geert Uytterhoeven]

Hi Miguel,

On Mon, Mar 22, 2021 at 5:59 PM Miguel Ojeda
<miguel.ojeda.sandonis@xxxxxxxxx> wrote:
> On Mon, Mar 22, 2021 at 3:48 PM Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> wrote:
> > +       struct device *dev = &pdev->dev;
>
> Do we want helpers like this to be `*const` (assuming they can)? (same
> for patch 12).

No, e.g. the devm_*() functions need to make changes to the device's
structure.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds